From ab8da122937f548f56b4b6efafc1fc4ca58bca90 Mon Sep 17 00:00:00 2001
From: liusuyi <1951119284@qq.com>
Date: Mon, 08 Dec 2025 13:49:33 +0800
Subject: [PATCH] 优化

---
 ard-work/src/main/java/com/ard/work/service/impl/ArdDroneInfoServiceImpl.java |   81 ++++++++++++++++++++++------------------
 1 files changed, 45 insertions(+), 36 deletions(-)

diff --git a/ard-work/src/main/java/com/ard/work/service/impl/ArdDroneInfoServiceImpl.java b/ard-work/src/main/java/com/ard/work/service/impl/ArdDroneInfoServiceImpl.java
index be4c9bc..cdc212c 100644
--- a/ard-work/src/main/java/com/ard/work/service/impl/ArdDroneInfoServiceImpl.java
+++ b/ard-work/src/main/java/com/ard/work/service/impl/ArdDroneInfoServiceImpl.java
@@ -284,58 +284,67 @@
      */
     @Scheduled(fixedRate = 1000 * 5)
     public void syncBoxInfo() {
-        ArdServerInfo ardServerInfo=new ArdServerInfo();
+        ArdServerInfo ardServerInfo = new ArdServerInfo();
         ardServerInfo.setUseDataScope(false);
         List<ArdServerInfo> servers = ardServerInfoService.selectArdServerInfoList(ardServerInfo);
-        servers.stream()
-                .filter(server -> server.getServerStatus().equals("1"))
-                .forEach(server -> {
-                            ArdDroneInfo droneInfo = new ArdDroneInfo();
-                            droneInfo.setServerId(server.getId());
-                            droneInfo.setUseDataScope(false);
-                            List<ArdDroneInfo> localList = selectArdDroneList(droneInfo);
-                            Map<String, ArdDroneInfo> localMap = localList.stream()
-                                    .collect(Collectors.toMap(ArdDroneInfo::getBoxSn, drone -> drone));
-                            List<BoxInfoReceiver> boxList = tyService.getBoxList(server.getId());
-                            if (boxList == null) {
-                                updateArdDrone(ArdDroneInfo.builder().serverId(server.getId()).onLine(0).build());
-                                return;
-                            }
-                            boxList.forEach(remote -> {
-                                String boxSn = remote.getBoxSn();
+        for (ArdServerInfo server : servers) {
+            ArdDroneInfo droneInfo = new ArdDroneInfo();
+            droneInfo.setServerId(server.getId());
+            droneInfo.setUseDataScope(false);
+            List<ArdDroneInfo> localList = selectArdDroneList(droneInfo);
+            Map<String, ArdDroneInfo> localMap = localList.stream()
+                    .collect(Collectors.toMap(ArdDroneInfo::getBoxSn, drone -> drone));
+            List<BoxInfoReceiver> boxList = tyService.getBoxList(server.getId());
+            if (boxList == null) {
+                updateArdDrone(ArdDroneInfo.builder().serverId(server.getId()).onLine(0).build());
+                continue;
+            }
+            for (BoxInfoReceiver remote : boxList) {
+                String boxSn = remote.getBoxSn();
+                String redisKey = CacheConstants.UAV_ONLINE_KEY + boxSn;
 
-                                // ✅ 维护在线状态缓存
-                                // 只有在线的无人机才存 Redis
-                                String redisKey = CacheConstants.UAV_ONLINE_KEY + boxSn;
-                                if (remote.getOnLine() == 1) {
-                                    redisCache.setCacheObject(redisKey, remote, 30, TimeUnit.SECONDS);
-                                } else {
-                                    redisCache.deleteObject(CacheConstants.UAV_ONLINE_KEY + boxSn);
-                                }
-                                // 数据库同步
-                                ArdDroneInfo local = localMap.get(boxSn);
-                                if (local != null && !local.isSameAs(remote)) {
-                                    updateChangedAttributes(local, remote);
-                                    updateArdDrone(local);
-                                }
-                            });
-                        });
+                // 只处理在线的 Redis
+                if (remote.getOnLine() == 1) {
+                    redisCache.setCacheObject(redisKey, remote, 30, TimeUnit.SECONDS);
+                } else {
+                    redisCache.deleteObject(redisKey);
+                }
+
+                // 数据库同步
+                ArdDroneInfo local = localMap.get(boxSn);
+                if (local == null) continue;
+
+                if (updateChangedAttributes(local, remote)) {
+                    updateArdDrone(local); // 只有真的有变化才更新数据库
+                }
+            }
+        }
     }
+    /**
+     * 更新 localBoxInfo 的字段,如果有变化返回 true,否则返回 false
+     */
+    private boolean updateChangedAttributes(ArdDroneInfo localBoxInfo, BoxInfoReceiver remoteArdDrone) {
+        boolean changed = false;
 
-    // 更新变化的属性
-    private void updateChangedAttributes(ArdDroneInfo localBoxInfo, BoxInfoReceiver remoteArdDrone) {
         if (!Objects.equals(localBoxInfo.getBoxName(), remoteArdDrone.getBoxName())) {
             localBoxInfo.setBoxName(remoteArdDrone.getBoxName());
+            changed = true;
         }
         if (!Objects.equals(localBoxInfo.getBoxVersion(), remoteArdDrone.getBoxVersion())) {
             localBoxInfo.setBoxVersion(remoteArdDrone.getBoxVersion());
+            changed = true;
         }
         if (!Objects.equals(localBoxInfo.getLastTaskId(), remoteArdDrone.getLastTaskId())) {
             localBoxInfo.setLastTaskId(remoteArdDrone.getLastTaskId());
+            changed = true;
         }
         if (!Objects.equals(localBoxInfo.getOnLine(), remoteArdDrone.getOnLine())) {
             localBoxInfo.setOnLine(remoteArdDrone.getOnLine());
+            changed = true;
         }
-        // 更新其他属性
+
+        // TODO: 更新其他属性时,如果变化也设置 changed = true
+
+        return changed;
     }
 }

--
Gitblit v1.9.3