From c15f1503faf94498b2c97a926c915337ecce0e87 Mon Sep 17 00:00:00 2001
From: liusuyi <1951119284@qq.com>
Date: Thu, 27 Nov 2025 14:20:54 +0800
Subject: [PATCH] 优化
---
ard-sample/src/main/java/com/ard/sample/manage/service/impl/DeviceServiceImpl.java | 86 +++++++++++++++++++++++++++++++------------
1 files changed, 62 insertions(+), 24 deletions(-)
diff --git a/ard-sample/src/main/java/com/ard/sample/manage/service/impl/DeviceServiceImpl.java b/ard-sample/src/main/java/com/ard/sample/manage/service/impl/DeviceServiceImpl.java
index 816c596..417c3ca 100644
--- a/ard-sample/src/main/java/com/ard/sample/manage/service/impl/DeviceServiceImpl.java
+++ b/ard-sample/src/main/java/com/ard/sample/manage/service/impl/DeviceServiceImpl.java
@@ -1,10 +1,7 @@
package com.ard.sample.manage.service.impl;
import com.alibaba.fastjson2.JSONObject;
-import com.ard.common.annotation.DataScope;
-import com.ard.common.annotation.DataScopePlus;
import com.ard.system.authorize.service.AuthorizeService;
-import com.baomidou.mybatisplus.core.conditions.Wrapper;
import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
import com.baomidou.mybatisplus.core.conditions.update.LambdaUpdateWrapper;
@@ -351,6 +348,7 @@
// subDevice.setPayloadsList(payloadService.getDevicePayloadEntitiesByDeviceSn(gateway.getChildDeviceSn()));
}
+ //region 单独写一个方法做权限验证，由于有好多定时任务也在实时获取设备列表，原方法不适用再添加权限注解
@Override
public List<DeviceDTO> getDockList() {
List<DeviceDTO> devicesList = this.getDockListByParams(
@@ -368,27 +366,21 @@
@Override
public void spliceDeviceTopoPer(DeviceDTO gateway) {
-
gateway.setStatus(RedisOpsUtils.checkExist(RedisConst.DEVICE_ONLINE_PREFIX + gateway.getDeviceSn()));
-
// sub device
if (!StringUtils.hasText(gateway.getChildDeviceSn())) {
return;
}
-
DeviceDTO subDevice =
getDevicesByParams(DeviceQueryParam.builder().deviceSn(gateway.getChildDeviceSn()).build()).get(0);
subDevice.setStatus(RedisOpsUtils.checkExist(RedisConst.DEVICE_ONLINE_PREFIX + subDevice.getDeviceSn()));
gateway.setChildren(subDevice);
-
- // payloads
- // subDevice.setPayloadsList(payloadService.getDevicePayloadEntitiesByDeviceSn(gateway.getChildDeviceSn()));
}
- //@DataScope(deptAlias = "d")
+
@Override
public List<DeviceDTO> getDockListByParams(DeviceQueryParam param){
-
+ // 在mapper中添加查询方法做权限验证
return mapper.selectListPer(
new LambdaQueryWrapper<DeviceEntity>()
.eq(StringUtils.hasText(param.getDeviceSn()),
@@ -412,6 +404,7 @@
.map(this::deviceEntityConvertToDTO)
.collect(Collectors.toList());
}
+ //endregion
@Override
public Optional<TopologyDeviceDTO> getDeviceTopoForPilot(String sn) {
@@ -619,6 +612,7 @@
// 验证授权数量
validateAuthorization(devicesList.size(), 1);
} catch (Exception e) {
+ log.error("保存设备时验证授权异常，请联系管理员！错误信息：" + e.getMessage());
return Optional.empty();
}
// 调用验证方法
@@ -880,6 +874,9 @@
BindDeviceReceiver dock = null;
BindDeviceReceiver drone = null;
for (BindDeviceReceiver device : devices) {
+ if(device.getDeviceModelKey().isEmpty()){
+ continue;
+ }
int val = Integer.parseInt(device.getDeviceModelKey().split("-")[0]);
if (val == DeviceDomainEnum.DOCK.getVal()) {
dock = device;
@@ -1076,6 +1073,16 @@
this.deviceOnePropertySet(topic, propertyEnum, Map.entry(propertyEnum.getProperty(), param));
return;
}
+
+ if(param.size()==1){
+ this.deviceOnePropertySetSilent(topic,propertyEnum,param);
+ return;
+ }
+// if(Objects.equals(param.fieldNames().next(), "silent_mode"))
+// {
+// this.deviceOnePropertySet(topic, propertyEnum, Map.entry(propertyEnum.getProperty(), param.get("silent_mode")));
+// return;
+// }
// If there are multiple parameters, set them separately.
for (Iterator<Map.Entry<String, JsonNode>> filed = param.fields(); filed.hasNext(); ) {
Map.Entry<String, JsonNode> node = filed.next();
@@ -1083,12 +1090,34 @@
if (!isPublish) {
continue;
}
+
this.deviceOnePropertySet(topic, propertyEnum, Map.entry(propertyEnum.getProperty(), node));
}
}
+ /**
+ * 为静音模式单独列出来一个方法，只有一个值的时候都可以调用，不限于静音模式
+ * */
@Override
+ public void deviceOnePropertySetSilent(String topic, DeviceSetPropertyEnum propertyEnum,
+ JsonNode value) {
+// if (Objects.isNull(value) || Objects.isNull(value.getValue())) {
+// throw new IllegalArgumentException(CommonErrorEnum.ILLEGAL_ARGUMENT.getErrorMsg());
+// }
+
+ Map reply = messageSender.publishWithReply(
+ Map.class, topic,
+ CommonTopicResponse.builder()
+ .bid(UUID.randomUUID().toString())
+ .tid(UUID.randomUUID().toString())
+ .timestamp(System.currentTimeMillis())
+ .data(value)
+ .build(),
+ 2);
+ }
+
+ @Override
public void deviceOnePropertySet(String topic, DeviceSetPropertyEnum propertyEnum,
Map.Entry<String, Object> value) {
if (Objects.isNull(value) || Objects.isNull(value.getValue())) {
@@ -1105,20 +1134,29 @@
.build(),
2);
- while (true) {
- reply = (Map<String, Object>) reply.get(value.getKey());
- if (value.getValue() instanceof JsonNode) {
- break;
- }
- value = (Map.Entry) value.getValue();
- }
-
- SetReply setReply = objectMapper.convertValue(reply, SetReply.class);
- if (SetReplyStatusResultEnum.SUCCESS.getVal() != setReply.getResult()) {
- throw new RuntimeException("Failed to set " + value.getKey() + "; Error Code: " + setReply.getResult());
- }
+// 接收返回信息在serviceReply中，订阅thing/product/7CTDLCE00A1UPE/property/set_reply上报的信息，此处不处理
+// while (true) {
+// reply = (Map<String, Object>) reply.get(value.getKey());
+// if (value.getValue() instanceof JsonNode) {
+// break;
+// }
+// value = (Map.Entry) value.getValue();
+// }
+// SetReply setReply = objectMapper.convertValue(reply, SetReply.class);
+// if (SetReplyStatusResultEnum.SUCCESS.getVal() != setReply.getResult()) {
+// throw new RuntimeException("Failed to set " + value.getKey() + "; Error Code: " + setReply.getResult());
+// }
}
+
+// public JsonNode getJsonNode(JsonNode jsonNode) {
+// ObjectNode parentNode = objectMapper.createObjectNode();
+// parentNode.put("bid", UUID.randomUUID().toString());
+// parentNode.set("data", jsonNode);
+// parentNode.put("tid", UUID.randomUUID().toString());
+// parentNode.put("timestamp", System.currentTimeMillis());
+// return parentNode;
+// }
@Override
public Boolean checkDeviceOnline(String sn) {
@@ -1209,7 +1247,7 @@
.sn(device.getDeviceSn())
.deviceCallsign(device.getNickname())
.isDeviceBindOrganization(device.getBoundStatus())
- .organizationId(device.getDeptId().toString())
+ .organizationId(String.valueOf(device.getDeptId()))
.organizationName(device.getWorkspaceName())
.build();
}
--
Gitblit v1.9.3