From ed23f121eee69f16af12be92bc92ee117d64e004 Mon Sep 17 00:00:00 2001
From: liusuyi <1951119284@qq.com>
Date: Tue, 20 Jan 2026 14:18:46 +0800
Subject: [PATCH] 优化

---
 ard-work/src/main/java/com/ard/work/service/impl/ArdDroneInfoServiceImpl.java |  138 ++++++++++++++++++----------------------------
 1 files changed, 54 insertions(+), 84 deletions(-)

diff --git a/ard-work/src/main/java/com/ard/work/service/impl/ArdDroneInfoServiceImpl.java b/ard-work/src/main/java/com/ard/work/service/impl/ArdDroneInfoServiceImpl.java
index 9d6b7f9..567281a 100644
--- a/ard-work/src/main/java/com/ard/work/service/impl/ArdDroneInfoServiceImpl.java
+++ b/ard-work/src/main/java/com/ard/work/service/impl/ArdDroneInfoServiceImpl.java
@@ -164,7 +164,7 @@
      * @return 成功插入的记录数
      */
     @Override
-    public int insertArdDroneLs(String[] boxSn, Long deptId) {
+    public int insertArdDroneLs(String[] boxSn,Long deptId,String serverId) {
         // 参数校验
         if (boxSn == null || boxSn.length == 0) {
             log.warn("传入的盒子编码为空");
@@ -176,12 +176,12 @@
         try {
             // 1. 检查已存在的无人机盒子
             List<ArdDroneInfo> existingDrones = getExistingDrones(boxSn);
-            // 1.1 新增时不能添加重复的
+            // 1.1 新增时不能添加重复的boxSn
             checkDuplicateBox(existingDrones, boxSn);
             // 2. 授权数量验证
             validateAuthorization(existingDrones.size(), boxSn.length);
             // 3. 获取并组装新的无人机信息
-            List<ArdDroneInfo> newDrones = assembleNewDrones(boxSn, deptId);
+            List<ArdDroneInfo> newDrones = assembleNewDrones(boxSn,deptId,serverId);
             // 4. 批量插入
             return batchInsertDrones(newDrones);
         } catch (Exception e) {
@@ -261,19 +261,19 @@
     /**
      * 组装新的无人机信息
      */
-    private List<ArdDroneInfo> assembleNewDrones(String[] boxSn, Long deptId) {
+    private List<ArdDroneInfo> assembleNewDrones(String[] boxSn,Long deptId,String serverId) {
         List<BoxInfoReceiver> allBoxes = tyService.getBoxList();
         Set<String> targetBoxSnSet = new HashSet<>(Arrays.asList(boxSn));
         return allBoxes.stream()
                 .filter(box -> targetBoxSnSet.contains(box.getBoxSn()))
-                .map(box -> createDroneInfo(box, deptId))
+                .map(box -> createDroneInfo(box, deptId, serverId))
                 .collect(Collectors.toList());
     }
 
     /**
      * 创建无人机信息对象
      */
-    private ArdDroneInfo createDroneInfo(BoxInfoReceiver box, Long deptId) {
+    private ArdDroneInfo createDroneInfo(BoxInfoReceiver box, Long deptId ,String serverId) {
         ArdDroneInfo drone = new ArdDroneInfo();
         drone.setId(IdUtils.simpleUUID());
         drone.setBoxSn(box.getBoxSn());
@@ -284,21 +284,13 @@
         drone.setVideoPort(box.getVideoPort());
         drone.setLastTaskId(box.getLastTaskId());
         drone.setDeptId(deptId);
-
-        // 设置创建信息和更新信息
-        setCreateAndUpdateInfo(drone);
-
+        drone.setCreateTime(new Date());
+        drone.setUpdateTime(new Date());
+        drone.setServerId(serverId);
+        drone.setBoxVersion(box.getBoxVersion());
         return drone;
     }
 
-    /**
-     * 设置创建和更新信息
-     */
-    private void setCreateAndUpdateInfo(ArdDroneInfo drone) {
-        Date currentTime = new Date();
-        drone.setCreateTime(currentTime);
-        drone.setUpdateTime(currentTime);
-    }
 
     /**
      * 批量插入无人机信息
@@ -315,87 +307,65 @@
      */
     @Scheduled(fixedRate = 5000)
     public void syncBoxInfo() {
-        ArdServerInfo ardServerInfo = new ArdServerInfo();
-        ardServerInfo.setUseDataScope(false);
-        List<ArdServerInfo> servers = ardServerInfoService.selectArdServerInfoList(ardServerInfo);
+        log.debug("定时执行同步盒子属性任务");
+        try {
+            ArdServerInfo ardServerInfo = new ArdServerInfo();
+            ardServerInfo.setUseDataScope(false);
+            List<ArdServerInfo> servers = ardServerInfoService.selectArdServerInfoList(ardServerInfo);
 
-        for (ArdServerInfo server : servers) {
-            ArdDroneInfo droneInfo = new ArdDroneInfo();
-            droneInfo.setServerId(server.getId());
-            droneInfo.setUseDataScope(false);
-            List<ArdDroneInfo> localList = selectArdDroneList(droneInfo);
-            Map<String, ArdDroneInfo> localMap = localList.stream().collect(Collectors.toMap(ArdDroneInfo::getBoxSn,
-                    d -> d));
-            List<BoxInfoReceiver> boxList = tyService.getBoxList(server.getId());
-            // server 没有返回设备列表 → 全部离线
-            if (boxList == null || boxList.isEmpty()) {
-                for (ArdDroneInfo local : localList) {
-                    if (local.getOnLine() != 0) { // 仅当状态变化才更新
-                        local.setOnLine(0);
-                        ArdDroneInfoMapper.updateArdDrone(local);
-                        eventPublisher.publishEvent(new DeviceStatusEvent(local.getBoxSn(), false));
-                        redisCache.deleteObject(CacheConstants.UAV_ONLINE_KEY + local.getBoxSn());
+            for (ArdServerInfo server : servers) {
+                ArdDroneInfo droneInfo = new ArdDroneInfo();
+                droneInfo.setServerId(server.getId());
+                droneInfo.setUseDataScope(false);
+                List<ArdDroneInfo> localList = selectArdDroneList(droneInfo);
+                Map<String, ArdDroneInfo> localMap = localList.stream().collect(Collectors.toMap(ArdDroneInfo::getBoxSn,
+                        d -> d));
+                List<BoxInfoReceiver> boxList = tyService.getBoxList(server.getId());
+                // server 没有返回设备列表 → 全部离线
+                if (boxList == null || boxList.isEmpty()) {
+                    for (ArdDroneInfo local : localList) {
+                        if (local.getOnLine() != 0) { // 仅当状态变化才更新
+                            local.setOnLine(0);
+                            ArdDroneInfoMapper.updateArdDrone(local);
+                            eventPublisher.publishEvent(new DeviceStatusEvent(local.getBoxSn(), false));
+                            redisCache.deleteObject(CacheConstants.UAV_ONLINE_KEY + local.getBoxSn());
+                        }
                     }
+                    continue;
                 }
-                continue;
-            }
-            // server 返回设备列表 →  通过缓存判断状态
-            for (BoxInfoReceiver remote : boxList) {
-                String boxSn = remote.getBoxSn();
-                String redisKey = CacheConstants.UAV_ONLINE_KEY + boxSn;
-                boolean currentOnline = remote.getOnLine() == 1;
+                // server 返回设备列表 →  通过缓存判断状态
+                for (BoxInfoReceiver remote : boxList) {
+                    String boxSn = remote.getBoxSn();
+                    String redisKey = CacheConstants.UAV_ONLINE_KEY + boxSn;
+                    boolean currentOnline = remote.getOnLine() == 1;
 
-                ArdDroneInfo local = localMap.get(boxSn);
-                boolean dbOnline = local != null && local.getOnLine() == 1;
-                boolean needUpdate = (dbOnline != currentOnline);
-
-                // 如果状态变化才更新
-                if (needUpdate){
-                    // 更新 Redis
+                    ArdDroneInfo local = localMap.get(boxSn);
+                    boolean dbOnline = local != null && local.getOnLine() == 1;
+                    boolean needUpdate = (dbOnline != currentOnline);
+                    // 只要远端设备在线,就刷新Redis缓存(无论状态是否变化),保证缓存一定存在
                     if (currentOnline) {
                         redisCache.setCacheObject(redisKey, remote);
                     } else {
+                        // 远端离线,删除Redis缓存
                         redisCache.deleteObject(redisKey);
                     }
-                    // 发布事件
-                    eventPublisher.publishEvent(new DeviceStatusEvent(boxSn, currentOnline));
-                    // 更新数据库
-                    if (local != null) {
-                        local.setOnLine(currentOnline ? 1 : 0);
-                        updateArdDrone(local);
+                    // 如果状态变化才更新
+                    if (needUpdate) {
+                        // 发布事件
+                        eventPublisher.publishEvent(new DeviceStatusEvent(boxSn, currentOnline));
+                        // 更新数据库
+                        if (local != null) {
+                            local.setOnLine(currentOnline ? 1 : 0);
+                            updateArdDrone(local);
+                        }
                     }
                 }
             }
+        } catch (Exception e) {
+            log.error("同步盒子属性任务异常", e);
         }
     }
 
 
-    /**
-     * 更新 localBoxInfo 的字段,如果有变化返回 true,否则返回 false
-     */
-    private boolean updateChangedAttributes(ArdDroneInfo localBoxInfo, BoxInfoReceiver remoteArdDrone) {
-        boolean changed = false;
-
-        if (!Objects.equals(localBoxInfo.getBoxName(), remoteArdDrone.getBoxName())) {
-            localBoxInfo.setBoxName(remoteArdDrone.getBoxName());
-            changed = true;
-        }
-        if (!Objects.equals(localBoxInfo.getBoxVersion(), remoteArdDrone.getBoxVersion())) {
-            localBoxInfo.setBoxVersion(remoteArdDrone.getBoxVersion());
-            changed = true;
-        }
-        if (!Objects.equals(localBoxInfo.getLastTaskId(), remoteArdDrone.getLastTaskId())) {
-            localBoxInfo.setLastTaskId(remoteArdDrone.getLastTaskId());
-            changed = true;
-        }
-        if (!Objects.equals(localBoxInfo.getOnLine(), remoteArdDrone.getOnLine())) {
-            localBoxInfo.setOnLine(remoteArdDrone.getOnLine());
-            changed = true;
-        }
-
-        // TODO: 更新其他属性时,如果变化也设置 changed = true
-
-        return changed;
-    }
 
 }

--
Gitblit v1.9.3